Glasgow | 25-SDC-Nov | Katarzyna Kazimierczuk | Sprint 3 | Middleware #73
Glasgow | 25-SDC-Nov | Katarzyna Kazimierczuk | Sprint 3 | Middleware #73katarzynakaz wants to merge 7 commits into
Conversation
katarzynakaz
added
📅 Sprint 3
OracPrime
added
the
Review in progress
OracPrime
added
Reviewed
katarzynakaz
added
the
Needs Review
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
I'm thoroughly confused by the bits other than mw1 and mw2. It's not clear how many separate projects there are, which bits are actually part of the project and which are just notes. It's a mess. Can you also remove .DS_Store - that's a MacOS desktop layout file and shouldn't be in git.
The submission needs to be much cleaner before I can approve it. I've asked on slack whether the prep tasks are needed: I don't think anyone else has done them - they certainly shouldn't be mixed in with the backlog commit of mw1 and mw2
OracPrime
removed
the
Needs Review
|
thank you for the feedback, I cleaned up the codebase and updated websocket.mjs with the requested fixes. |
katarzynakaz
added
Needs Review
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
There's still lots of tidying up needed, and a few bugs to fix
OracPrime
removed
the
Needs Review
…aned, innerhtml, moved listener to div
thank you, all completed |
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
There are a few comments to read and understand, but since these are outside the backlog coursework, just understand them, don't fix them unless you really want to! Although the one about vsCode warnings for tag typos is important. If you're not getting that flagged by vsCode, contact me and we'll work out why
OracPrime
added
the
Complete
2 participants
Self checklist
Changelist
Prep 3 exercises: chat like/dislike functionality and middleware exercises.